chore: Handling plural translations #30645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 65e4e5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #30645 +/- ##
===========================================
+ Coverage 49.55% 49.58% +0.02%
===========================================
Files 3307 3311 +4
Lines 81426 81472 +46
Branches 16699 16707 +8
===========================================
+ Hits 40349 40394 +45
+ Misses 36383 36380 -3
- Partials 4694 4698 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
This reverts commit d2dd116.
yash-rajpal
changed the title
tassoevan
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Why not to use the own i18next pluralization handling? https://www.i18next.com/translation-function/plurals
tassoevan
force-pushed
the
plural-translations
branch
from
6bef693 to
be1718b
Compare
tassoevan
approved these changes
Jan 15, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
TC-993